Skip to content

Pass username/password to Cassandra docker-compose health check #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2024
Merged

Pass username/password to Cassandra docker-compose health check #6214

merged 3 commits into from
Nov 17, 2024

Conversation

@akstron
Copy link
Contributor

@akstron akstron commented Nov 16, 2024 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Added the username and password values for health check cmd
  • Added healthcheck_cassandra point to make sure the container is healthy as per the cmd.

How was this change tested?

  • bash scripts/cassandra-integration-test.sh 4 v004 v1
  • bash scripts/cassandra-integration-test.sh 4 v004 v2

Checklist

@codecov
Copy link

codecov bot commented Nov 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (6585c6e) to head (c747574).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6214   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         354      354           
  Lines       20127    20127           
=======================================
  Hits        19418    19418           
  Misses        524      524           
  Partials      185      185
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v2 1.66% <ø> (-0.02%) ⬇️
grpc_v1 9.47% <ø> (ø)
grpc_v2 7.00% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (ø)
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.67% <ø> (+0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akstron akstron marked this pull request as ready for review November 16, 2024 13:49
@akstron akstron requested a review from a team as a code owner November 16, 2024 13:49
@akstron akstron requested a review from joe-elliott November 16, 2024 13:49
@dosubot dosubot bot added docker Pull requests that update Docker code storage/cassandra labels Nov 16, 2024
yurishkuro
yurishkuro approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this change, but I would like to understand what specifically it's fixing since our CI was fine without it. And if it fixes a real problem then why didn't our CI catch it before.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 16, 2024
@akstron
Copy link
Contributor Author

akstron commented Nov 16, 2024

I don't mind this change, but I would like to understand what specifically it's fixing since our CI was fine without it. And if it fixes a real problem then why didn't our CI catch it before.

Replied in the issue linked. Thanks

yurishkuro
yurishkuro reviewed Nov 16, 2024
View reviewed changes
@akstron
Fix cassandra docker-compose health check
ccd7348 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron
shell lint fix
3dfd947 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron
Added timeout for healthcheck
c747574 
Signed-off-by: Alok Kumar Singh <[email protected]>
@akstron akstron force-pushed the cassandra-docker-compose-fix-2 branch from 164aca2 to c747574 Compare November 17, 2024 05:24
@yurishkuro yurishkuro changed the title Fix Cassandra docker-compose health check Pass username/password to Cassandra docker-compose health check Nov 17, 2024
@yurishkuro yurishkuro merged commit 47e1ee6 into jaegertracing:main Nov 17, 2024
50 checks passed
@yurishkuro
Copy link
Member

yurishkuro commented Nov 17, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees

No one assigned

Labels

changelog:ci Change related to continuous integration / testing docker Pull requests that update Docker code storage/cassandra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: cassandra container never becomes healthy

2 participants

@akstron @yurishkuro